Closed
Bug 662051
Opened 14 years ago
Closed 14 years ago
Port |Bug 608934 - About window needs a close button| to comm-central
Categories
(Thunderbird :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 7.0
People
(Reporter: hidenosuke, Assigned: t.matsuu)
Details
Attachments
(2 files, 1 obsolete file)
|
83.06 KB,
image/png
|
Details | |
|
1.13 KB,
patch
|
standard8
:
review+
|
Details | Diff | Splinter Review |
Screenshot for About dialog
Firefox about dialog has close button now by bug 608934.
I think Thunderbird about dialog should have close button too.
|
Assignee | |
Updated•14 years ago
|
Summary: About window needs a close button → Port |Bug 608934 - About window needs a close button| to comm-central
|
|
Assignee | |
Comment 1•14 years ago
|
||
Please try this for Thunderbird.
|
|
Assignee | |
Comment 2•14 years ago
|
||
I suppose the same fix is required for calendar.
|
||
Comment 3•14 years ago
|
||
Comment on attachment 537435 [details] [diff] [review]
Port bug 608934 to Thunderbird
It looks like I've seen this code already - but can't find the checking.
Attachment #537435 -
Flags: review?(mbanner)
|
|
||
Comment 4•14 years ago
|
||
(In reply to comment #3)
> Comment on attachment 537435 [details] [diff] [review] [review]
> Port bug 608934 to Thunderbird
>
> It looks like I've seen this code already - but can't find the checking.
Can you raise a bug in Calendar for that and request review to :fallen , thanks.
|
|
||
Comment 5•14 years ago
|
||
|
|
Assignee | |
Comment 6•14 years ago
|
||
(In reply to comment #4)
> Can you raise a bug in Calendar for that and request review to :fallen ,
> thanks.
File bug 662244 for comment 2.
|
|
Assignee | |
Updated•14 years ago
|
Attachment #537436 -
Attachment is obsolete: true
|
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → t.matsuu
|
||
Comment 7•14 years ago
|
||
Comment on attachment 537435 [details] [diff] [review]
Port bug 608934 to Thunderbird
Thanks for the patch.
Attachment #537435 -
Flags: review?(mbanner) → review+
|
|
||
Comment 8•14 years ago
|
||
Takanori do you have checkin rights ?
|
|
Assignee | |
Updated•14 years ago
|
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 10•14 years ago
|
||
Is there any action required for checkin-needed?
|
|
||
Comment 11•14 years ago
|
||
(In reply to comment #10)
> Is there any action required for checkin-needed?
no it will come on time.
|
|
||
Comment 12•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
You need to log in
before you can comment on or make changes to this bug.
Description
•