Closed Bug 662051 Opened 13 years ago Closed 13 years ago

Port |Bug 608934 - About window needs a close button| to comm-central

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 7.0

People

(Reporter: hidenosuke, Assigned: t.matsuu)

Details

Attachments

(2 files, 1 obsolete file)

Screenshot for About dialog
83.06 KB, image/png
Details
Port bug 608934 to Thunderbird
1.13 KB, patch
standard8
: review+
Details | Diff | Splinter Review 
Firefox about dialog has close button now by bug 608934.
I think Thunderbird about dialog should have close button too.
Summary: About window needs a close button → Port |Bug 608934 - About window needs a close button| to comm-central
Please try this for Thunderbird.
Attached patch Port 608934 to calendar (obsolete) — — Splinter Review 
I suppose the same fix is required for calendar.
Comment on attachment 537435 [details] [diff] [review]
Port bug 608934 to Thunderbird

It looks like I've seen this code already - but can't find the checking.
Attachment #537435 - Flags: review?(mbanner)
(In reply to comment #3)
> Comment on attachment 537435 [details] [diff] [review] [review]
> Port bug 608934 to Thunderbird
> 
> It looks like I've seen this code already - but can't find the checking.

Can you raise a bug in Calendar for that and request review to :fallen , thanks.
My previous reply was for comment 2 not comment 3 :(
(In reply to comment #4)
> Can you raise a bug in Calendar for that and request review to :fallen ,
> thanks.

File bug 662244 for comment 2.
Attachment #537436 - Attachment is obsolete: true
Assignee: nobody → t.matsuu
Comment on attachment 537435 [details] [diff] [review]
Port bug 608934 to Thunderbird

Thanks for the patch.
Attachment #537435 - Flags: review?(mbanner) → review+
Takanori do you have checkin rights ?
No.

I've set checkin-needed.
Keywords: checkin-needed
Status: NEW → ASSIGNED
Is there any action required for checkin-needed?
(In reply to comment #10)
> Is there any action required for checkin-needed?

no it will come on time.
Checked in: http://hg.mozilla.org/comm-central/rev/a264f7b23016
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: